diff options
| author | Peter Zijlstra <peterz@infradead.org> | 2020-03-12 01:07:42 +0300 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2020-03-25 20:28:30 +0300 |
| commit | 8887a86eddd93ca396ca35f7b41fb14ed412f85d (patch) | |
| tree | 05b495acfcc330eff1fa75ced3f31ee46be520c5 /tools/objtool | |
| parent | 8b5fa6bc326bf02f293b5a39a8f5b3de816265d3 (diff) | |
| download | linux-8887a86eddd93ca396ca35f7b41fb14ed412f85d.tar.xz | |
objtool: Delete cleanup()
Perf shows we spend a measurable amount of time spend cleaning up
right before we exit anyway. Avoid the needsless work and just
terminate.
This reduces objtool on vmlinux.o runtime from 5.4s to 4.8s
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Link: https://lkml.kernel.org/r/20200324160924.800720170@infradead.org
Diffstat (limited to 'tools/objtool')
| -rw-r--r-- | tools/objtool/check.c | 19 |
1 files changed, 0 insertions, 19 deletions
diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 54a604381a03..0c9c9ad47467 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -2458,23 +2458,6 @@ static int validate_reachable_instructions(struct objtool_file *file) return 0; } -static void cleanup(struct objtool_file *file) -{ - struct instruction *insn, *tmpinsn; - struct alternative *alt, *tmpalt; - - list_for_each_entry_safe(insn, tmpinsn, &file->insn_list, list) { - list_for_each_entry_safe(alt, tmpalt, &insn->alts, list) { - list_del(&alt->list); - free(alt); - } - list_del(&insn->list); - hash_del(&insn->hash); - free(insn); - } - elf_close(file->elf); -} - static struct objtool_file file; int check(const char *_objname, bool orc) @@ -2542,8 +2525,6 @@ int check(const char *_objname, bool orc) } out: - cleanup(&file); - if (ret < 0) { /* * Fatal error. The binary is corrupt or otherwise broken in |