diff options
| author | Peter Zijlstra <peterz@infradead.org> | 2020-03-12 11:34:42 +0300 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2020-03-25 20:28:29 +0300 |
| commit | 2a362ecc3ec9632aeea4b9a9062db91b2bd9975a (patch) | |
| tree | 862c13b17b3b80cd22d5e7d82a9c16254720b494 /tools/objtool/elf.h | |
| parent | ae358196fac3a0b4d2a7d47a4f401e3421027b03 (diff) | |
| download | linux-2a362ecc3ec9632aeea4b9a9062db91b2bd9975a.tar.xz | |
objtool: Optimize find_symbol_*() and read_symbols()
All of:
read_symbols(), find_symbol_by_offset(), find_symbol_containing(),
find_containing_func()
do a linear search of the symbols. Add an RB tree to make it go
faster.
This about halves objtool runtime on vmlinux.o, from 34s to 18s.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Link: https://lkml.kernel.org/r/20200324160924.499016559@infradead.org
Diffstat (limited to 'tools/objtool/elf.h')
| -rw-r--r-- | tools/objtool/elf.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tools/objtool/elf.h b/tools/objtool/elf.h index ac7c46f7d9ab..e4a8d68f2ef7 100644 --- a/tools/objtool/elf.h +++ b/tools/objtool/elf.h @@ -10,6 +10,7 @@ #include <gelf.h> #include <linux/list.h> #include <linux/hashtable.h> +#include <linux/rbtree.h> #include <linux/jhash.h> #ifdef LIBELF_USE_DEPRECATED @@ -29,6 +30,7 @@ struct section { struct hlist_node hash; struct hlist_node name_hash; GElf_Shdr sh; + struct rb_root symbol_tree; struct list_head symbol_list; struct list_head rela_list; DECLARE_HASHTABLE(rela_hash, 16); @@ -43,6 +45,7 @@ struct section { struct symbol { struct list_head list; + struct rb_node node; struct hlist_node hash; GElf_Sym sym; struct section *sec; |