diff options
| author | Andrii Nakryiko <andrii@kernel.org> | 2022-04-26 03:45:04 +0300 |
|---|---|---|
| committer | Alexei Starovoitov <ast@kernel.org> | 2022-04-27 01:41:46 +0300 |
| commit | 966a7509325395c51c5f6d89e7352b0585e4804b (patch) | |
| tree | 9ee96d3f6f87ae09ba75e67b5be0790fc612b763 /tools/lib | |
| parent | 0994a54c5202114ad0e3b3a0f1326e810b23ad38 (diff) | |
| download | linux-966a7509325395c51c5f6d89e7352b0585e4804b.tar.xz | |
libbpf: Fix logic for finding matching program for CO-RE relocation
Fix the bug in bpf_object__relocate_core() which can lead to finding
invalid matching BPF program when processing CO-RE relocation. IF
matching program is not found, last encountered program will be assumed
to be correct program and thus error detection won't detect the problem.
Fixes: 9c82a63cf370 ("libbpf: Fix CO-RE relocs against .text section")
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20220426004511.2691730-4-andrii@kernel.org
Diffstat (limited to 'tools/lib')
| -rw-r--r-- | tools/lib/bpf/libbpf.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index b8cc862687a2..946b4590c4d3 100644 --- a/tools/lib/bpf/libbpf.c +++ b/tools/lib/bpf/libbpf.c @@ -5677,9 +5677,10 @@ bpf_object__relocate_core(struct bpf_object *obj, const char *targ_btf_path) */ prog = NULL; for (i = 0; i < obj->nr_programs; i++) { - prog = &obj->programs[i]; - if (strcmp(prog->sec_name, sec_name) == 0) + if (strcmp(obj->programs[i].sec_name, sec_name) == 0) { + prog = &obj->programs[i]; break; + } } if (!prog) { pr_warn("sec '%s': failed to find a BPF program\n", sec_name); |