diff options
author | Jiri Olsa <jolsa@redhat.com> | 2021-04-26 21:27:32 +0300 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2021-04-29 16:31:00 +0300 |
commit | fbed59f844912f377b83cc25594c692b5f6ebae2 (patch) | |
tree | 15289f915c9c56f06d11245608dde395bed43ec3 /tools/build/Makefile.feature | |
parent | 81e70d7ee4ae13d60800958bca9d3c7675de16c9 (diff) | |
download | linux-fbed59f844912f377b83cc25594c692b5f6ebae2.tar.xz |
perf build: Regenerate the FEATURE_DUMP file after extra feature checks
Feature detection is done in tools/build/Makefile.feature, we may exit
there with some features not detected and then, in
tools/perf/Makefile.config try adding extra libraries to link and then
do extra feature checks to see if we now find the feature.
This is the case with the disassembler-four-args that checks if the
diassembler() function in libopcodes (binutils) has a signature with
one or with four arguments, as this is not ABI and they changed it at
some point.
This is not a problem when doing normal builds, for instance:
$ make -C tools/perf O=/tmp/build/perf
As we don't use what is in FEATURE-DUMP at that point, but is a problem
if we pass FEATURE_DUMP=/previously-detected-features as we do in
'make -C tools/perf build-test' to reuse the feature detection in the
many build combinations we test there.
When that is done feature-disassembler-four-args will be set to 0, but
opensuse 15.1 has the four arguments function signature in
disassembler(). The build thus fails.
Fix it by rewriting the FEATURE-DUMP file at the end of
tools/perf/Makefile.config to register features we retested in that make
file.
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/build/Makefile.feature')
0 files changed, 0 insertions, 0 deletions