summaryrefslogtreecommitdiff
path: root/sound
diff options
context:
space:
mode:
authorYufen Yu <yuyufen@huawei.com>2021-05-24 12:35:21 +0300
committerMark Brown <broonie@kernel.org>2021-06-03 16:00:01 +0300
commit81aad47278539f02de808bcc8251fed0ad3d6f55 (patch)
tree61f97001c0fac1070fbaf827c9adc234d9f18ec2 /sound
parent28b170110a7683ee12af7e81f1b5868bc7fcb62f (diff)
downloadlinux-81aad47278539f02de808bcc8251fed0ad3d6f55.tar.xz
ASoC: img: Fix PM reference leak in img_i2s_in_probe()
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yufen Yu <yuyufen@huawei.com> Link: https://lore.kernel.org/r/20210524093521.612176-1-yuyufen@huawei.com Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
-rw-r--r--sound/soc/img/img-i2s-in.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/img/img-i2s-in.c b/sound/soc/img/img-i2s-in.c
index 0843235d73c9..fd3432a1d6ab 100644
--- a/sound/soc/img/img-i2s-in.c
+++ b/sound/soc/img/img-i2s-in.c
@@ -464,7 +464,7 @@ static int img_i2s_in_probe(struct platform_device *pdev)
if (ret)
goto err_pm_disable;
}
- ret = pm_runtime_get_sync(&pdev->dev);
+ ret = pm_runtime_resume_and_get(&pdev->dev);
if (ret < 0)
goto err_suspend;