diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2018-03-04 17:35:49 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2018-03-07 15:40:14 +0300 |
| commit | 1cf5b50426136fe54380a7dd1ca7eb49973cae5a (patch) | |
| tree | 84e5a27c510eee39adcadfe25d3063224f5035ac /sound/soc/codecs/rt5651.h | |
| parent | f1088d4b813fb4d20fc9e8e8db5ca252923f25eb (diff) | |
| download | linux-1cf5b50426136fe54380a7dd1ca7eb49973cae5a.tar.xz | |
ASoC: rt5651: Make rt5651_apply_properties() private
The idea behind exporting rt5651_apply_properties(), was for it to be used
on platforms where the platform code may need to add device-properties,
rather then relying only on properties set by the firmware. The platform
code could then call rt5651_apply_properties() after adding properties to
make sure that the codec driver was aware of the new properties.
But this is not necessary, as long as we do all property parsing from
the codec component-driver's probe function (or later) then the machine
driver can attach properties before calling snd_soc_register_card and
calling rt5651_apply_properties() for ordering reasons is not necessary.
This commit makes rt5651_apply_properties() private and adds 2 comments
documenting that all property parsing must be done from the codec
component-driver's probe function.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/codecs/rt5651.h')
| -rw-r--r-- | sound/soc/codecs/rt5651.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/sound/soc/codecs/rt5651.h b/sound/soc/codecs/rt5651.h index 7d9d5fa09d6f..f3158488fc89 100644 --- a/sound/soc/codecs/rt5651.h +++ b/sound/soc/codecs/rt5651.h @@ -2080,6 +2080,4 @@ struct rt5651_priv { bool hp_mute; }; -void rt5651_apply_properties(struct snd_soc_component *component); - #endif /* __RT5651_H__ */ |