diff options
author | Alexander Kuznetsov <wwfq@yandex-team.ru> | 2021-06-09 10:17:19 +0300 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2021-06-10 16:58:50 +0300 |
commit | b7e24eb1caa5f8da20d405d262dba67943aedc42 (patch) | |
tree | 69baa641c0dba6e5b9c25ff0d86fd8226d262791 /sound/hda/trace.h | |
parent | 08b2b6fdf6b26032f025084ce2893924a0cdb4a2 (diff) | |
download | linux-b7e24eb1caa5f8da20d405d262dba67943aedc42.tar.xz |
cgroup1: don't allow '\n' in renaming
cgroup_mkdir() have restriction on newline usage in names:
$ mkdir $'/sys/fs/cgroup/cpu/test\ntest2'
mkdir: cannot create directory
'/sys/fs/cgroup/cpu/test\ntest2': Invalid argument
But in cgroup1_rename() such check is missed.
This allows us to make /proc/<pid>/cgroup unparsable:
$ mkdir /sys/fs/cgroup/cpu/test
$ mv /sys/fs/cgroup/cpu/test $'/sys/fs/cgroup/cpu/test\ntest2'
$ echo $$ > $'/sys/fs/cgroup/cpu/test\ntest2'
$ cat /proc/self/cgroup
11:pids:/
10:freezer:/
9:hugetlb:/
8:cpuset:/
7:blkio:/user.slice
6:memory:/user.slice
5:net_cls,net_prio:/
4:perf_event:/
3:devices:/user.slice
2:cpu,cpuacct:/test
test2
1:name=systemd:/
0::/
Signed-off-by: Alexander Kuznetsov <wwfq@yandex-team.ru>
Reported-by: Andrey Krasichkov <buglloc@yandex-team.ru>
Acked-by: Dmitry Yakunin <zeil@yandex-team.ru>
Cc: stable@vger.kernel.org
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'sound/hda/trace.h')
0 files changed, 0 insertions, 0 deletions