summaryrefslogtreecommitdiff
path: root/sound/drivers
diff options
context:
space:
mode:
authorHui Peng <benquike@gmail.com>2019-08-15 07:31:34 +0300
committerTakashi Iwai <tiwai@suse.de>2019-08-15 22:48:52 +0300
commit19bce474c45be69a284ecee660aa12d8f1e88f18 (patch)
tree9a58decee9c325aa1dc879780b3bc778d6793e36 /sound/drivers
parentdaac07156b330b18eb5071aec4b3ddca1c377f2c (diff)
downloadlinux-19bce474c45be69a284ecee660aa12d8f1e88f18.tar.xz
ALSA: usb-audio: Fix a stack buffer overflow bug in check_input_term
`check_input_term` recursively calls itself with input from device side (e.g., uac_input_terminal_descriptor.bCSourceID) as argument (id). In `check_input_term`, if `check_input_term` is called with the same `id` argument as the caller, it triggers endless recursive call, resulting kernel space stack overflow. This patch fixes the bug by adding a bitmap to `struct mixer_build` to keep track of the checked ids and stop the execution if some id has been checked (similar to how parse_audio_unit handles unitid argument). Reported-by: Hui Peng <benquike@gmail.com> Reported-by: Mathias Payer <mathias.payer@nebelwelt.net> Signed-off-by: Hui Peng <benquike@gmail.com> Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/drivers')
0 files changed, 0 insertions, 0 deletions