diff options
author | Yonghong Song <yhs@fb.com> | 2018-02-14 06:00:21 +0300 |
---|---|---|
committer | Alexei Starovoitov <ast@kernel.org> | 2018-02-14 06:15:16 +0300 |
commit | 9a3efb6b661f71d5675369ace9257833f0e78ef3 (patch) | |
tree | 3748be036eb13ba033f358045cf42599fe04f3ad /scripts/leaking_addresses.pl | |
parent | d4014d8cc6dfa964e3e66df525de2384e3583018 (diff) | |
download | linux-9a3efb6b661f71d5675369ace9257833f0e78ef3.tar.xz |
bpf: fix memory leak in lpm_trie map_free callback function
There is a memory leak happening in lpm_trie map_free callback
function trie_free. The trie structure itself does not get freed.
Also, trie_free function did not do synchronize_rcu before freeing
various data structures. This is incorrect as some rcu_read_lock
region(s) for lookup, update, delete or get_next_key may not complete yet.
The fix is to add synchronize_rcu in the beginning of trie_free.
The useless spin_lock is removed from this function as well.
Fixes: b95a5c4db09b ("bpf: add a longest prefix match trie map implementation")
Reported-by: Mathieu Malaterre <malat@debian.org>
Reported-by: Alexei Starovoitov <ast@kernel.org>
Tested-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Yonghong Song <yhs@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'scripts/leaking_addresses.pl')
0 files changed, 0 insertions, 0 deletions