diff options
| author | Andreas Gruenbacher <agruen@suse.de> | 2008-07-31 02:03:49 +0400 |
|---|---|---|
| committer | Sam Ravnborg <sam@ravnborg.org> | 2008-08-01 01:00:25 +0400 |
| commit | 94aa3d716ee0244cc5b9f2ab3745aed5fdfa30e0 (patch) | |
| tree | 0003889647cfdbabb5db12555eb5967177e226fc /scripts/genksyms/parse.y | |
| parent | 11ddad396086f8d1dfcb0056dc9d65d228f755c1 (diff) | |
| download | linux-94aa3d716ee0244cc5b9f2ab3745aed5fdfa30e0.tar.xz | |
kbuild: genksyms parser: fix the __attribute__ rule
We are having two kinds of problems with genksyms today: fake checksum
changes without actual ABI changes, and changes which we would rather like
to ignore (such as an additional field at the end of a structure that
modules are not supposed to touch, for example).
I have thought about ways to improve genksyms and compute checksums
differently to avoid those problems, but in the end I don't see a
fundamentally better way. So here are some genksyms patches for at least
making the checksums more easily manageable, if we cannot fully fix them.
In addition to the bugfixes (the first two patches), this allows genksyms
to track checksum changes and report why a checksum changed (third patch),
and to selectively ignore changes (fourth patch).
This patch:
Gcc __attribute__ definitions may occur repeatedly, e.g.,
static int foo __attribute__((__used__))
__attribute__((aligned (16)));
The genksyms parser does not understand this, and generates a syntax error.
Fix this case.
Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Diffstat (limited to 'scripts/genksyms/parse.y')
| -rw-r--r-- | scripts/genksyms/parse.y | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/genksyms/parse.y b/scripts/genksyms/parse.y index 408cdf82b271..10d7dc724b6d 100644 --- a/scripts/genksyms/parse.y +++ b/scripts/genksyms/parse.y @@ -446,7 +446,7 @@ member_bitfield_declarator: attribute_opt: /* empty */ { $$ = NULL; } - | ATTRIBUTE_PHRASE + | attribute_opt ATTRIBUTE_PHRASE ; asm_definition: |