diff options
author | Daniel Jordan <daniel.m.jordan@oracle.com> | 2022-11-17 04:28:02 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-12-31 15:32:34 +0300 |
commit | 6cfa9e60c0f88fdec6368e081ab968411cc706b1 (patch) | |
tree | df24480acc6cdd82f04d1b9b05d81db32cec8d1c /samples/v4l | |
parent | 314398bc1014d9d407ef3c03f4c864607a066382 (diff) | |
download | linux-6cfa9e60c0f88fdec6368e081ab968411cc706b1.tar.xz |
padata: Always leave BHs disabled when running ->parallel()
[ Upstream commit 34c3a47d20ae55b3600fed733bf96eafe9c500d5 ]
A deadlock can happen when an overloaded system runs ->parallel() in the
context of the current task:
padata_do_parallel
->parallel()
pcrypt_aead_enc/dec
padata_do_serial
spin_lock(&reorder->lock) // BHs still enabled
<interrupt>
...
__do_softirq
...
padata_do_serial
spin_lock(&reorder->lock)
It's a bug for BHs to be on in _do_serial as Steffen points out, so
ensure they're off in the "current task" case like they are in
padata_parallel_worker to avoid this situation.
Reported-by: syzbot+bc05445bc14148d51915@syzkaller.appspotmail.com
Fixes: 4611ce224688 ("padata: allocate work structures for parallel jobs from a pool")
Signed-off-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'samples/v4l')
0 files changed, 0 insertions, 0 deletions