diff options
author | Stefano Brivio <sbrivio@redhat.com> | 2019-03-08 18:40:57 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-03-08 22:27:21 +0300 |
commit | ad6c9986bcb627c7c22b8f9e9a934becc27df87c (patch) | |
tree | 5056ffd00fa5c22c0d80b8f65e432f21af5db59f /net | |
parent | 930c9f9125c85b5134b3e711bc252ecc094708e3 (diff) | |
download | linux-ad6c9986bcb627c7c22b8f9e9a934becc27df87c.tar.xz |
vxlan: Fix GRO cells race condition between receive and link delete
If we receive a packet while deleting a VXLAN device, there's a chance
vxlan_rcv() is called at the same time as vxlan_dellink(). This is fine,
except that vxlan_dellink() should never ever touch stuff that's still in
use, such as the GRO cells list.
Otherwise, vxlan_rcv() crashes while queueing packets via
gro_cells_receive().
Move the gro_cells_destroy() to vxlan_uninit(), which runs after the RCU
grace period is elapsed and nothing needs the gro_cells anymore.
This is now done in the same way as commit 8e816df87997 ("geneve: Use GRO
cells infrastructure.") originally implemented for GENEVE.
Reported-by: Jianlin Shi <jishi@redhat.com>
Fixes: 58ce31cca1ff ("vxlan: GRO support at tunnel layer")
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions