diff options
| author | Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-13 23:52:05 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-07-15 13:49:56 +0300 |
| commit | 2a85388f1d94a9f8b5a529118a2c5eaa0520d85c (patch) | |
| tree | be7e59944c5768ed3dac9e02356e866d9106d753 /net | |
| parent | 92c0aa4175474483d6cf373314343d4e624e882a (diff) | |
| download | linux-2a85388f1d94a9f8b5a529118a2c5eaa0520d85c.tar.xz | |
tcp: Fix a data-race around sysctl_tcp_probe_interval.
While reading sysctl_tcp_probe_interval, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: 05cbc0db03e8 ("ipv4: Create probe timer for tcp PMTU as per RFC4821")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv4/tcp_output.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index aa757c74dad4..02ab3a9c6657 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c @@ -2283,7 +2283,7 @@ static inline void tcp_mtu_check_reprobe(struct sock *sk) u32 interval; s32 delta; - interval = net->ipv4.sysctl_tcp_probe_interval; + interval = READ_ONCE(net->ipv4.sysctl_tcp_probe_interval); delta = tcp_jiffies32 - icsk->icsk_mtup.probe_timestamp; if (unlikely(delta >= interval * HZ)) { int mss = tcp_current_mss(sk); |