summaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorJakub Kicinski <kuba@kernel.org>2021-03-25 04:11:59 +0300
committerDavid S. Miller <davem@davemloft.net>2021-03-26 02:46:53 +0300
commit42ce127d98641f2cb19cd499b5b3beb472c7eff1 (patch)
treef2188b4114169376bd5e2883732b370aae68f56a /net
parentd3b37fc805d9ef697451730ebdfc7e35e6c2ace8 (diff)
downloadlinux-42ce127d98641f2cb19cd499b5b3beb472c7eff1.tar.xz
ethtool: fec: sanitize ethtool_fecparam->fec
Reject NONE on set, this mode means device does not support FEC so it's a little out of place in the set interface. This should be safe to do - user space ethtool does not allow the use of NONE on set. A few drivers treat it the same as OFF, but none use it instead of OFF. Similarly reject an empty FEC mask. The common user space tool will not send such requests and most drivers correctly reject it already. Signed-off-by: Jakub Kicinski <kuba@kernel.org> Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/ethtool/ioctl.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
index 237ffe5440ef..8797533ddc4b 100644
--- a/net/ethtool/ioctl.c
+++ b/net/ethtool/ioctl.c
@@ -2586,6 +2586,9 @@ static int ethtool_set_fecparam(struct net_device *dev, void __user *useraddr)
if (copy_from_user(&fecparam, useraddr, sizeof(fecparam)))
return -EFAULT;
+ if (!fecparam.fec || fecparam.fec & ETHTOOL_FEC_NONE_BIT)
+ return -EINVAL;
+
fecparam.active_fec = 0;
fecparam.reserved = 0;