diff options
author | Cong Wang <xiyou.wangcong@gmail.com> | 2018-08-06 21:06:02 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-08-07 22:39:13 +0300 |
commit | 455f05ecd2b219e9a216050796d30c830d9bc393 (patch) | |
tree | ddd03269c5845932976a7e947b6efc2d168cea80 /net/tipc | |
parent | a94cead71c4651da5649134e3cdc29b1f32327a2 (diff) | |
download | linux-455f05ecd2b219e9a216050796d30c830d9bc393.tar.xz |
vsock: split dwork to avoid reinitializations
syzbot reported that we reinitialize an active delayed
work in vsock_stream_connect():
ODEBUG: init active (active state 0) object type: timer_list hint:
delayed_work_timer_fn+0x0/0x90 kernel/workqueue.c:1414
WARNING: CPU: 1 PID: 11518 at lib/debugobjects.c:329
debug_print_object+0x16a/0x210 lib/debugobjects.c:326
The pattern is apparently wrong, we should only initialize
the dealyed work once and could repeatly schedule it. So we
have to move out the initializations to allocation side.
And to avoid confusion, we can split the shared dwork
into two, instead of re-using the same one.
Fixes: d021c344051a ("VSOCK: Introduce VM Sockets")
Reported-by: <syzbot+8a9b1bd330476a4f3db6@syzkaller.appspotmail.com>
Cc: Andy king <acking@vmware.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Jorgen Hansen <jhansen@vmware.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tipc')
0 files changed, 0 insertions, 0 deletions