diff options
| author | Zhang Xiaoxu <zhangxiaoxu5@huawei.com> | 2021-06-26 10:50:41 +0300 |
|---|---|---|
| committer | Trond Myklebust <trond.myklebust@hammerspace.com> | 2021-06-28 16:34:39 +0300 |
| commit | fcb170a9d825d7db4a3fb870b0300f5a40a8d096 (patch) | |
| tree | 171c63b1fab9dc492a643c6142c96b230492bae2 /net/switchdev | |
| parent | b42ad64f5f216db05310783cbded56176c3a09df (diff) | |
| download | linux-fcb170a9d825d7db4a3fb870b0300f5a40a8d096.tar.xz | |
SUNRPC: Fix the batch tasks count wraparound.
The 'queue->nr' will wraparound from 0 to 255 when only current
priority queue has tasks. This maybe lead a deadlock same as commit
dfe1fe75e00e ("NFSv4: Fix deadlock between nfs4_evict_inode()
and nfs4_opendata_get_inode()"):
Privileged delegreturn task is queued to privileged list because all
the slots are assigned. When non-privileged task complete and release
the slot, a non-privileged maybe picked out. It maybe allocate slot
failed when the session on draining.
If the 'queue->nr' has wraparound to 255, and no enough slot to
service it, then the privileged delegreturn will lost to wake up.
So we should avoid the wraparound on 'queue->nr'.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 5fcdfacc01f3 ("NFSv4: Return delegations synchronously in evict_inode")
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable@vger.kernel.org
Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Diffstat (limited to 'net/switchdev')
0 files changed, 0 insertions, 0 deletions