diff options
author | Chuck Lever <chuck.lever@oracle.com> | 2019-10-24 16:34:16 +0300 |
---|---|---|
committer | J. Bruce Fields <bfields@redhat.com> | 2019-10-30 23:32:37 +0300 |
commit | 5866efa8cbfbadf3905072798e96652faf02dbe8 (patch) | |
tree | b02eae553499e2c0a32b9721aac3ac37b9696cb4 /net/sunrpc/xprtmultipath.c | |
parent | ff27e9f748303e8567bfceb6d7ff264cbcaca2ef (diff) | |
download | linux-5866efa8cbfbadf3905072798e96652faf02dbe8.tar.xz |
SUNRPC: Fix svcauth_gss_proxy_init()
gss_read_proxy_verf() assumes things about the XDR buffer containing
the RPC Call that are not true for buffers generated by
svc_rdma_recv().
RDMA's buffers look more like what the upper layer generates for
sending: head is a kmalloc'd buffer; it does not point to a page
whose contents are contiguous with the first page in the buffers'
page array. The result is that ACCEPT_SEC_CONTEXT via RPC/RDMA has
stopped working on Linux NFS servers that use gssproxy.
This does not affect clients that use only TCP to send their
ACCEPT_SEC_CONTEXT operation (that's all Linux clients). Other
clients, like Solaris NFS clients, send ACCEPT_SEC_CONTEXT on the
same transport as they send all other NFS operations. Such clients
can send ACCEPT_SEC_CONTEXT via RPC/RDMA.
I thought I had found every direct reference in the server RPC code
to the rqstp->rq_pages field.
Bug found at the 2019 Westford NFS bake-a-thon.
Fixes: 3316f0631139 ("svcrdma: Persistently allocate and DMA- ... ")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Tested-by: Bill Baker <bill.baker@oracle.com>
Reviewed-by: Simo Sorce <simo@redhat.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'net/sunrpc/xprtmultipath.c')
0 files changed, 0 insertions, 0 deletions