diff options
author | Jiri Pirko <jiri@mellanox.com> | 2018-02-13 13:22:42 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-02-13 20:22:29 +0300 |
commit | 0f2d2b2736b08dafa3bde31d048750fbc8df3a31 (patch) | |
tree | 82204c267dbe44d87749a3d32f48bd0303da1bb4 /net/sched/cls_u32.c | |
parent | d4e9a408ef5de35dd82c1337b9fe48348b70047c (diff) | |
download | linux-0f2d2b2736b08dafa3bde31d048750fbc8df3a31.tar.xz |
mlxsw: spectrum_router: Fix error path in mlxsw_sp_vr_create
Since mlxsw_sp_fib_create() and mlxsw_sp_mr_table_create()
use ERR_PTR macro to propagate int err through return of a pointer,
the return value is not NULL in case of failure. So if one
of the calls fails, one of vr->fib4, vr->fib6 or vr->mr4_table
is not NULL and mlxsw_sp_vr_is_used wrongly assumes
that vr is in use which leads to crash like following one:
[ 1293.949291] BUG: unable to handle kernel NULL pointer dereference at 00000000000006c9
[ 1293.952729] IP: mlxsw_sp_mr_table_flush+0x15/0x70 [mlxsw_spectrum]
Fix this by using local variables to hold the pointers and set vr->*
only in case everything went fine.
Fixes: 76610ebbde18 ("mlxsw: spectrum_router: Refactor virtual router handling")
Fixes: a3d9bc506d64 ("mlxsw: spectrum_router: Extend virtual routers with IPv6 support")
Fixes: d42b0965b1d4 ("mlxsw: spectrum_router: Add multicast routes notification handling functionality")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/cls_u32.c')
0 files changed, 0 insertions, 0 deletions