diff options
| author | Cong Wang <xiyou.wangcong@gmail.com> | 2020-04-03 06:58:51 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-04-04 02:00:08 +0300 |
| commit | a8eab6d35e22f4f21471f16147be79529cd6aaf7 (patch) | |
| tree | 368d450c2049ba3b8f99e712940356130a143d28 /net/sched/cls_tcindex.c | |
| parent | 3e1221acf6a8f8595b5ce354bab4327a69d54d18 (diff) | |
| download | linux-a8eab6d35e22f4f21471f16147be79529cd6aaf7.tar.xz | |
net_sched: fix a missing refcnt in tcindex_init()
The initial refcnt of struct tcindex_data should be 1,
it is clear that I forgot to set it to 1 in tcindex_init().
This leads to a dec-after-zero warning.
Reported-by: syzbot+8325e509a1bf83ec741d@syzkaller.appspotmail.com
Fixes: 304e024216a8 ("net_sched: add a temporary refcnt for struct tcindex_data")
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Cc: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/cls_tcindex.c')
| -rw-r--r-- | net/sched/cls_tcindex.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/sched/cls_tcindex.c b/net/sched/cls_tcindex.c index 065345832a69..61e95029c18f 100644 --- a/net/sched/cls_tcindex.c +++ b/net/sched/cls_tcindex.c @@ -151,6 +151,7 @@ static int tcindex_init(struct tcf_proto *tp) p->mask = 0xffff; p->hash = DEFAULT_HASH_SIZE; p->fall_through = 1; + refcount_set(&p->refcnt, 1); /* Paired with tcindex_destroy_work() */ rcu_assign_pointer(tp->root, p); return 0; |