diff options
| author | Vlad Buslov <vladbu@mellanox.com> | 2020-02-17 13:12:12 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-02-18 01:17:02 +0300 |
| commit | b15e7a6e8d31d6abe2d98929d60ad3a0e6ae4de1 (patch) | |
| tree | 3b1986c5151784433053007868f85e4046cd06de /net/sched/cls_api.c | |
| parent | 107f2d50916500985b9fffd7c77d8c14809f9802 (diff) | |
| download | linux-b15e7a6e8d31d6abe2d98929d60ad3a0e6ae4de1.tar.xz | |
net: sched: don't take rtnl lock during flow_action setup
Refactor tc_setup_flow_action() function not to use rtnl lock and remove
'rtnl_held' argument that is no longer needed.
Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/cls_api.c')
| -rw-r--r-- | net/sched/cls_api.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index 610505117780..13c33eaf1ca1 100644 --- a/net/sched/cls_api.c +++ b/net/sched/cls_api.c @@ -3433,7 +3433,7 @@ static void tcf_sample_get_group(struct flow_action_entry *entry, } int tc_setup_flow_action(struct flow_action *flow_action, - const struct tcf_exts *exts, bool rtnl_held) + const struct tcf_exts *exts) { struct tc_action *act; int i, j, k, err = 0; @@ -3441,9 +3441,6 @@ int tc_setup_flow_action(struct flow_action *flow_action, if (!exts) return 0; - if (!rtnl_held) - rtnl_lock(); - j = 0; tcf_exts_for_each_action(i, act, exts) { struct flow_action_entry *entry; @@ -3577,9 +3574,6 @@ int tc_setup_flow_action(struct flow_action *flow_action, } err_out: - if (!rtnl_held) - rtnl_unlock(); - if (err) tc_cleanup_flow_action(flow_action); |