diff options
author | Loris Reiff <loris.reiff@liblor.ch> | 2021-01-22 19:42:31 +0300 |
---|---|---|
committer | Daniel Borkmann <daniel@iogearbox.net> | 2021-01-23 01:11:34 +0300 |
commit | bb8b81e396f7afbe7c50d789e2107512274d2a35 (patch) | |
tree | cd23fb2afd862ab950fe23fb80ba8cc20ed37cb7 /net/netlabel/netlabel_mgmt.h | |
parent | 35c715c30b95205e64311c3bb3525094cd3d7236 (diff) | |
download | linux-bb8b81e396f7afbe7c50d789e2107512274d2a35.tar.xz |
bpf, cgroup: Fix optlen WARN_ON_ONCE toctou
A toctou issue in `__cgroup_bpf_run_filter_getsockopt` can trigger a
WARN_ON_ONCE in a check of `copy_from_user`.
`*optlen` is checked to be non-negative in the individual getsockopt
functions beforehand. Changing `*optlen` in a race to a negative value
will result in a `copy_from_user(ctx.optval, optval, ctx.optlen)` with
`ctx.optlen` being a negative integer.
Fixes: 0d01da6afc54 ("bpf: implement getsockopt and setsockopt hooks")
Signed-off-by: Loris Reiff <loris.reiff@liblor.ch>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Stanislav Fomichev <sdf@google.com>
Link: https://lore.kernel.org/bpf/20210122164232.61770-1-loris.reiff@liblor.ch
Diffstat (limited to 'net/netlabel/netlabel_mgmt.h')
0 files changed, 0 insertions, 0 deletions