summaryrefslogtreecommitdiff
path: root/net/key
diff options
context:
space:
mode:
authorTycho Andersen <tycho@tycho.ws>2019-01-12 21:24:20 +0300
committerJames Morris <james.morris@microsoft.com>2019-01-15 20:43:12 +0300
commita811dc61559e0c8003f1086c2a4dc8e4d5ae4cb8 (patch)
tree56144b909f723d0bf4365c2ccbd8ec2e24d9907d /net/key
parent7939f8beecf1cfb10d255be65bfbd3793fae82a1 (diff)
downloadlinux-a811dc61559e0c8003f1086c2a4dc8e4d5ae4cb8.tar.xz
seccomp: fix UAF in user-trap code
On the failure path, we do an fput() of the listener fd if the filter fails to install (e.g. because of a TSYNC race that's lost, or if the thread is killed, etc.). fput() doesn't actually release the fd, it just ads it to a work queue. Then the thread proceeds to free the filter, even though the listener struct file has a reference to it. To fix this, on the failure path let's set the private data to null, so we know in ->release() to ignore the filter. Reported-by: syzbot+981c26489b2d1c6316ba@syzkaller.appspotmail.com Fixes: 6a21cc50f0c7 ("seccomp: add a return code to trap to userspace") Signed-off-by: Tycho Andersen <tycho@tycho.ws> Acked-by: Kees Cook <keescook@chromium.org> Signed-off-by: James Morris <james.morris@microsoft.com>
Diffstat (limited to 'net/key')
0 files changed, 0 insertions, 0 deletions