diff options
| author | Eric Dumazet <edumazet@google.com> | 2023-09-12 19:02:10 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-09-15 12:33:48 +0300 |
| commit | 83cd5eb654b320c1972254f243531f3f3cebcccf (patch) | |
| tree | a8d72a0578be0a6c28249b7792498117fb84fee6 /net/ipv6/ip6_output.c | |
| parent | 3cccda8db2cf2f2a224d55d5b6e2251d478c58ca (diff) | |
| download | linux-83cd5eb654b320c1972254f243531f3f3cebcccf.tar.xz | |
ipv6: lockless IPV6_ROUTER_ALERT_ISOLATE implementation
Reads from np->rtalert_isolate are racy.
Move this flag to inet->inet_flags to fix data-races.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/ip6_output.c')
| -rw-r--r-- | net/ipv6/ip6_output.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 8851fe5d45a0..f87d8491d7e2 100644 --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@ -368,9 +368,8 @@ static int ip6_call_ra_chain(struct sk_buff *skb, int sel) if (sk && ra->sel == sel && (!sk->sk_bound_dev_if || sk->sk_bound_dev_if == skb->dev->ifindex)) { - struct ipv6_pinfo *np = inet6_sk(sk); - if (np && np->rtalert_isolate && + if (inet6_test_bit(RTALERT_ISOLATE, sk) && !net_eq(sock_net(sk), dev_net(skb->dev))) { continue; } |