summaryrefslogtreecommitdiff
path: root/net/ipv4/tcp_ulp.c
diff options
context:
space:
mode:
authorEric Dumazet <edumazet@google.com>2017-11-03 04:10:03 +0300
committerDavid S. Miller <davem@davemloft.net>2017-11-03 10:02:56 +0300
commitf67971e683e81d7ba4739728511ae6e52a1b6321 (patch)
treec960635bc9e1813044d72d838df112acc04fc9b2 /net/ipv4/tcp_ulp.c
parentc509a8229d8df29c8308c4b03a1f6d69eb287acd (diff)
downloadlinux-f67971e683e81d7ba4739728511ae6e52a1b6321.tar.xz
tcp: tcp_fragment() should not assume rtx skbs
While stress testing MTU probing, we had crashes in list_del() that we root-caused to the fact that tcp_fragment() is unconditionally inserting the freshly allocated skb into tsorted_sent_queue list. But this list is supposed to contain skbs that were sent. This was mostly harmless until MTU probing was enabled. Fortunately we can use the tcp_queue enum added later (but in same linux version) for rtx-rb-tree to fix the bug. Fixes: e2080072ed2d ("tcp: new list for sent but unacked skbs for RACK recovery") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Yuchung Cheng <ycheng@google.com> Cc: Neal Cardwell <ncardwell@google.com> Cc: Soheil Hassas Yeganeh <soheil@google.com> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Priyaranjan Jha <priyarjha@google.com> Acked-by: Neal Cardwell <ncardwell@google.com> Acked-by: Soheil Hassas Yeganeh <soheil@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_ulp.c')
0 files changed, 0 insertions, 0 deletions