diff options
| author | Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-12 03:15:30 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-07-13 14:56:49 +0300 |
| commit | 4785a66702f086cf2ea84bdbe6ec921f274bd9f2 (patch) | |
| tree | 28f36a4bf5f7825aacde839ad3286e1c1cec8a84 /net/ipv4/syncookies.c | |
| parent | 1dace014928e6e385363032d359a04dee9158af0 (diff) | |
| download | linux-4785a66702f086cf2ea84bdbe6ec921f274bd9f2.tar.xz | |
tcp: Fix data-races around sysctl_tcp_ecn.
While reading sysctl_tcp_ecn, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its readers.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/syncookies.c')
| -rw-r--r-- | net/ipv4/syncookies.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/syncookies.c b/net/ipv4/syncookies.c index f33c31dd7366..b387c4835155 100644 --- a/net/ipv4/syncookies.c +++ b/net/ipv4/syncookies.c @@ -273,7 +273,7 @@ bool cookie_ecn_ok(const struct tcp_options_received *tcp_opt, if (!ecn_ok) return false; - if (net->ipv4.sysctl_tcp_ecn) + if (READ_ONCE(net->ipv4.sysctl_tcp_ecn)) return true; return dst_feature(dst, RTAX_FEATURE_ECN); |