diff options
| author | Taehee Yoo <ap420073@gmail.com> | 2020-02-28 21:01:46 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-03-01 08:37:03 +0300 |
| commit | 4b793acdca0050739b99ace6a8b9e7f717f57c6b (patch) | |
| tree | 16fcb5ddb4723391340c0dbc037a4b391e1b0d05 /net/hsr | |
| parent | 13eeb5fea68e11765020b846ef692809c5fe04aa (diff) | |
| download | linux-4b793acdca0050739b99ace6a8b9e7f717f57c6b.tar.xz | |
hsr: use netdev_err() instead of WARN_ONCE()
When HSR interface is sending a frame, it finds a node with
the destination ethernet address from the list.
If there is no node, it calls WARN_ONCE().
But, using WARN_ONCE() for this situation is a little bit overdoing.
So, in this patch, the netdev_err() is used instead.
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/hsr')
| -rw-r--r-- | net/hsr/hsr_framereg.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/hsr/hsr_framereg.c b/net/hsr/hsr_framereg.c index 3ba7f61be107..d46d22c7105c 100644 --- a/net/hsr/hsr_framereg.c +++ b/net/hsr/hsr_framereg.c @@ -318,7 +318,8 @@ void hsr_addr_subst_dest(struct hsr_node *node_src, struct sk_buff *skb, node_dst = find_node_by_addr_A(&port->hsr->node_db, eth_hdr(skb)->h_dest); if (!node_dst) { - WARN_ONCE(1, "%s: Unknown node\n", __func__); + if (net_ratelimit()) + netdev_err(skb->dev, "%s: Unknown node\n", __func__); return; } if (port->type != node_dst->addr_B_port) |