diff options
| author | Cong Wang <xiyou.wangcong@gmail.com> | 2020-07-09 06:13:59 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-07-09 22:31:28 +0300 |
| commit | 306381aec7c2b5a658eebca008c8a1b666536cba (patch) | |
| tree | d28155bb389847c2f3821f7a759895c7b65be460 /net/ethtool/netlink.c | |
| parent | 13cf8aab7425a253070433b5a55b4209ceac8b19 (diff) | |
| download | linux-306381aec7c2b5a658eebca008c8a1b666536cba.tar.xz | |
net_sched: fix a memory leak in atm_tc_init()
When tcf_block_get() fails inside atm_tc_init(),
atm_tc_put() is called to release the qdisc p->link.q.
But the flow->ref prevents it to do so, as the flow->ref
is still zero.
Fix this by moving the p->link.ref initialization before
tcf_block_get().
Fixes: 6529eaba33f0 ("net: sched: introduce tcf block infractructure")
Reported-and-tested-by: syzbot+d411cff6ab29cc2c311b@syzkaller.appspotmail.com
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ethtool/netlink.c')
0 files changed, 0 insertions, 0 deletions