diff options
| author | Vladyslav Tarasiuk <vladyslavt@mellanox.com> | 2020-03-24 14:57:08 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-03-25 02:25:11 +0300 |
| commit | 9d648fb560e16d8973b081f25a8cc1b38c8393de (patch) | |
| tree | 47f4f37960a0d70ea69666b71d4dbc0096fb9603 /net/ethtool/ioctl.c | |
| parent | c9c1fd62b0ed32127d6af8409ae3ad0e9be70590 (diff) | |
| download | linux-9d648fb560e16d8973b081f25a8cc1b38c8393de.tar.xz | |
ethtool: fix incorrect tx-checksumming settings reporting
Currently, ethtool feature mask for checksum command is ORed with
NETIF_F_FCOE_CRC_BIT, which is bit's position number, instead of the
actual feature bit - NETIF_F_FCOE_CRC.
The invalid bitmask here might affect unrelated features when toggling
TX checksumming. For example, TX checksumming is always mistakenly
reported as enabled on the netdevs tested (mlx5, virtio_net).
Fixes: f70bb06563ed ("ethtool: update mapping of features to legacy ioctl requests")
Signed-off-by: Vladyslav Tarasiuk <vladyslavt@mellanox.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ethtool/ioctl.c')
| -rw-r--r-- | net/ethtool/ioctl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c index 3852a58d7f95..10d929abdf6a 100644 --- a/net/ethtool/ioctl.c +++ b/net/ethtool/ioctl.c @@ -196,7 +196,7 @@ static netdev_features_t ethtool_get_feature_mask(u32 eth_cmd) switch (eth_cmd) { case ETHTOOL_GTXCSUM: case ETHTOOL_STXCSUM: - return NETIF_F_CSUM_MASK | NETIF_F_FCOE_CRC_BIT | + return NETIF_F_CSUM_MASK | NETIF_F_FCOE_CRC | NETIF_F_SCTP_CRC; case ETHTOOL_GRXCSUM: case ETHTOOL_SRXCSUM: |