summaryrefslogtreecommitdiff
path: root/net/dsa
diff options
context:
space:
mode:
authorRasmus Villemoes <linux@rasmusvillemoes.dk>2022-11-16 13:52:03 +0300
committerJakub Kicinski <kuba@kernel.org>2022-11-18 06:40:08 +0300
commit6fdb038420407d9781b2ba2429f836434a25e91a (patch)
tree2d0b446778ec7757b814bd4a392fb08ce499df3b /net/dsa
parent0171a1d22bb99174671484f409f66f5b96c073b4 (diff)
downloadlinux-6fdb038420407d9781b2ba2429f836434a25e91a.tar.xz
net: dsa: use NET_NAME_PREDICTABLE for user ports with name given in DT
When a user port has a label in device tree, the corresponding netdevice is, to quote include/uapi/linux/netdevice.h, "predictably named by the kernel". This is also explicitly one of the intended use cases for NET_NAME_PREDICTABLE, quoting 685343fc3ba6 ("net: add name_assign_type netdev attribute"): NET_NAME_PREDICTABLE: The ifname has been assigned by the kernel in a predictable way [...] Examples include [...] and names deduced from hardware properties (including being given explicitly by the firmware). Expose that information properly for the benefit of userspace tools that make decisions based on the name_assign_type attribute, e.g. a systemd-udev rule with "kernel" in NamePolicy. Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Reviewed-by: Florian Fainelli <f.faineli@gmail.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/dsa')
-rw-r--r--net/dsa/slave.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index 2ae75d4d8389..5405b730eb92 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -2377,7 +2377,7 @@ int dsa_slave_create(struct dsa_port *port)
if (port->name) {
name = port->name;
- assign_type = NET_NAME_UNKNOWN;
+ assign_type = NET_NAME_PREDICTABLE;
} else {
name = "eth%d";
assign_type = NET_NAME_UNKNOWN;