diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2010-10-29 07:09:24 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-11-09 00:50:08 +0300 |
| commit | fc766e4c4965915ab52a1d1fa3c7a7b3e7bc07f0 (patch) | |
| tree | d45160f52eea37d4e5149d511c3c577bef253801 /net/decnet/dn_neigh.c | |
| parent | e4a7b93bd5d84e1e79917d024d17d745d190fc9a (diff) | |
| download | linux-fc766e4c4965915ab52a1d1fa3c7a7b3e7bc07f0.tar.xz | |
decnet: RCU conversion and get rid of dev_base_lock
While tracking dev_base_lock users, I found decnet used it in
dnet_select_source(), but for a wrong purpose:
Writers only hold RTNL, not dev_base_lock, so readers must use RCU if
they cannot use RTNL.
Adds an rcu_head in struct dn_ifaddr and handle proper RCU management.
Adds __rcu annotation in dn_route as well.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: Steven Whitehouse <swhiteho@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/decnet/dn_neigh.c')
| -rw-r--r-- | net/decnet/dn_neigh.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/decnet/dn_neigh.c b/net/decnet/dn_neigh.c index a085dbcf5c7f..602dade7e9a3 100644 --- a/net/decnet/dn_neigh.c +++ b/net/decnet/dn_neigh.c @@ -391,7 +391,7 @@ int dn_neigh_router_hello(struct sk_buff *skb) write_lock(&neigh->lock); neigh->used = jiffies; - dn_db = (struct dn_dev *)neigh->dev->dn_ptr; + dn_db = rcu_dereference(neigh->dev->dn_ptr); if (!(neigh->nud_state & NUD_PERMANENT)) { neigh->updated = jiffies; |