diff options
| author | Nikolay Aleksandrov <nikolay@nvidia.com> | 2021-01-29 14:51:42 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-01-30 08:33:02 +0300 |
| commit | 1e16f382ae0ba0a244ebeea5783153f5c4f7e6c1 (patch) | |
| tree | c3dd76a3ea175d046dee4a7c4bd59a59d2c6d216 /net/bridge | |
| parent | 7d0888d52faa8cc8cde05643d7ed267adc74f03f (diff) | |
| download | linux-1e16f382ae0ba0a244ebeea5783153f5c4f7e6c1.tar.xz | |
net: bridge: add warning comments to avoid extending sysfs
We're moving to netlink-only options, so add comments in the bridge's
sysfs files to warn against adding any new sysfs entries.
Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/bridge')
| -rw-r--r-- | net/bridge/br_sysfs_br.c | 4 | ||||
| -rw-r--r-- | net/bridge/br_sysfs_if.c | 4 |
2 files changed, 8 insertions, 0 deletions
diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c index 7db06e3f642a..71f0f671c4ef 100644 --- a/net/bridge/br_sysfs_br.c +++ b/net/bridge/br_sysfs_br.c @@ -19,6 +19,10 @@ #include "br_private.h" +/* IMPORTANT: new bridge options must be added with netlink support only + * please do not add new sysfs entries + */ + #define to_bridge(cd) ((struct net_bridge *)netdev_priv(to_net_dev(cd))) /* diff --git a/net/bridge/br_sysfs_if.c b/net/bridge/br_sysfs_if.c index 7a59cdddd3ce..96ff63cde1be 100644 --- a/net/bridge/br_sysfs_if.c +++ b/net/bridge/br_sysfs_if.c @@ -17,6 +17,10 @@ #include "br_private.h" +/* IMPORTANT: new bridge port options must be added with netlink support only + * please do not add new sysfs entries + */ + struct brport_attribute { struct attribute attr; ssize_t (*show)(struct net_bridge_port *, char *); |