diff options
| author | Ido Schimmel <idosch@mellanox.com> | 2018-02-25 22:59:06 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-02-26 23:15:53 +0300 |
| commit | 0e5a82efda872c2469c210957d7d4161ef8f4391 (patch) | |
| tree | 81ef619461f2efd5c28b05d427b64d6b38e02bca /net/bridge/br_vlan.c | |
| parent | 3a291aa11898bc9577c16339f108aac02ba0d109 (diff) | |
| download | linux-0e5a82efda872c2469c210957d7d4161ef8f4391.tar.xz | |
bridge: Fix VLAN reference count problem
When a VLAN is added on a port, a reference is taken on the
corresponding master VLAN entry. If it does not already exist, then it
is created and a reference taken.
However, in the second case a reference is not really taken when
CONFIG_REFCOUNT_FULL is enabled as refcount_inc() is replaced by
refcount_inc_not_zero().
Fix this by using refcount_set() on a newly created master VLAN entry.
Fixes: 251277598596 ("net, bridge: convert net_bridge_vlan.refcnt from atomic_t to refcount_t")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge/br_vlan.c')
| -rw-r--r-- | net/bridge/br_vlan.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c index 51935270c651..9896f4975353 100644 --- a/net/bridge/br_vlan.c +++ b/net/bridge/br_vlan.c @@ -168,6 +168,8 @@ static struct net_bridge_vlan *br_vlan_get_master(struct net_bridge *br, u16 vid masterv = br_vlan_find(vg, vid); if (WARN_ON(!masterv)) return NULL; + refcount_set(&masterv->refcnt, 1); + return masterv; } refcount_inc(&masterv->refcnt); |