diff options
author | Tejun Heo <tj@kernel.org> | 2013-03-09 00:43:30 +0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-03-09 03:05:34 +0400 |
commit | 2e1c9b2867656ff9a469d23e1dfe90cf77ec0c72 (patch) | |
tree | b1f8c8a5fde730b2e3c71239e125e451df039fa5 /net/9p | |
parent | 7880639c3e4fde5953ff243ee52204ddc5af641b (diff) | |
download | linux-2e1c9b2867656ff9a469d23e1dfe90cf77ec0c72.tar.xz |
idr: remove WARN_ON_ONCE() on negative IDs
idr_find(), idr_remove() and idr_replace() used to silently ignore the
sign bit and perform lookup with the rest of the bits. The weird behavior
has been changed such that negative IDs are treated as invalid. As the
behavior change was subtle, WARN_ON_ONCE() was added in the hope of
determining who's calling idr functions with negative IDs so that they can
be examined for problems.
Up until now, all two reported cases are ID number coming directly from
userland and getting fed into idr_find() and the warnings seem to cause
more problems than being helpful. Drop the WARN_ON_ONCE()s.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: <markus@trippelsdorf.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/9p')
0 files changed, 0 insertions, 0 deletions