diff options
| author | Kurt Kanzenbach <kurt@linutronix.de> | 2024-02-25 14:38:37 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-02-28 05:17:47 +0300 |
| commit | f72a1994698ebe1a9eeadba7bfe2aa01afcde0a4 (patch) | |
| tree | 408c8344dcaab8d530bf7b859876cdb2e942a83b /lib/locking-selftest-spin-hardirq.h | |
| parent | c68b2c9eba38ec3f60f4894b189090febf4d8d22 (diff) | |
| download | linux-f72a1994698ebe1a9eeadba7bfe2aa01afcde0a4.tar.xz | |
net: stmmac: Complete meta data only when enabled
Currently using plain XDP/ZC sockets on stmmac results in a kernel crash:
|[ 255.822584] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000
|[...]
|[ 255.822764] Call trace:
|[ 255.822766] stmmac_tx_clean.constprop.0+0x848/0xc38
The program counter indicates xsk_tx_metadata_complete(). It works on
compl->tx_timestamp, which is not set by xsk_tx_metadata_to_compl() due to
missing meta data. Therefore, call xsk_tx_metadata_complete() only when
meta data is actually used.
Tested on imx93 without XDP, with XDP and with XDP/ZC.
Fixes: 1347b419318d ("net: stmmac: Add Tx HWTS support to XDP ZC")
Suggested-by: Serge Semin <fancer.lancer@gmail.com>
Tested-by: Serge Semin <fancer.lancer@gmail.com>
Link: https://lore.kernel.org/netdev/87r0h7wg8u.fsf@kurt.kurt.home/
Acked-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
Link: https://lore.kernel.org/r/20240222-stmmac_xdp-v2-1-4beee3a037e4@linutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'lib/locking-selftest-spin-hardirq.h')
0 files changed, 0 insertions, 0 deletions