summaryrefslogtreecommitdiff
path: root/kernel
diff options
context:
space:
mode:
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>2020-12-15 12:20:30 +0300
committerGuenter Roeck <linux@roeck-us.net>2020-12-30 19:21:04 +0300
commit1eda52334e6d13eb1a85f713ce06dd39342b5020 (patch)
tree0fa3f0d27a960dc576165a63797b564731333737 /kernel
parente042f151ec7474b88b8c1edaaddd1ff7415d7117 (diff)
downloadlinux-1eda52334e6d13eb1a85f713ce06dd39342b5020.tar.xz
hwmon: (pwm-fan) Ensure that calculation doesn't discard big period values
With MAX_PWM being defined to 255 the code unsigned long period; ... period = ctx->pwm->args.period; state.duty_cycle = DIV_ROUND_UP(pwm * (period - 1), MAX_PWM); calculates a too small value for duty_cycle if the configured period is big (either by discarding the 64 bit value ctx->pwm->args.period or by overflowing the multiplication). As this results in a too slow fan and so maybe an overheating machine better be safe than sorry and error out in .probe. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20201215092031.152243-1-u.kleine-koenig@pengutronix.de Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'kernel')
0 files changed, 0 insertions, 0 deletions