diff options
| author | Tycho Andersen <tycho@tycho.pizza> | 2020-09-02 17:09:53 +0300 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2020-09-08 21:30:16 +0300 |
| commit | e839317900e9f13c83d8711d684de88c625b307a (patch) | |
| tree | 2b62afa93e55a872f5fa56e6f36bbd48a8b080e7 /kernel/sysctl.c | |
| parent | 19d1d49f2a8ce7adb10d93ff31909b0932c0d628 (diff) | |
| download | linux-e839317900e9f13c83d8711d684de88c625b307a.tar.xz | |
seccomp: don't leave dangling ->notif if file allocation fails
Christian and Kees both pointed out that this is a bit sloppy to open-code
both places, and Christian points out that we leave a dangling pointer to
->notif if file allocation fails. Since we check ->notif for null in order
to determine if it's ok to install a filter, this means people won't be
able to install a filter if the file allocation fails for some reason, even
if they subsequently should be able to.
To fix this, let's hoist this free+null into its own little helper and use
it.
Reported-by: Kees Cook <keescook@chromium.org>
Reported-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Tycho Andersen <tycho@tycho.pizza>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Link: https://lore.kernel.org/r/20200902140953.1201956-1-tycho@tycho.pizza
Signed-off-by: Kees Cook <keescook@chromium.org>
Diffstat (limited to 'kernel/sysctl.c')
0 files changed, 0 insertions, 0 deletions