diff options
author | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2011-01-07 15:41:40 +0300 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2011-01-07 17:55:45 +0300 |
commit | c9b5f501ef1580faa30c40c644b7691870462201 (patch) | |
tree | d22df12b72bc90b130254078ee71b1b7e7e3e521 /kernel/softirq.c | |
parent | 524429c31b486c05449666b94613f59f729c0a84 (diff) | |
download | linux-c9b5f501ef1580faa30c40c644b7691870462201.tar.xz |
sched: Constify function scope static struct sched_param usage
Function-scope statics are discouraged because they are
easily overlooked and can cause subtle bugs/races due to
their global (non-SMP safe) nature.
Linus noticed that we did this for sched_param - at minimum
make the const.
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: Message-ID: <AANLkTinotRxScOHEb0HgFgSpGPkq_6jKTv5CfvnQM=ee@mail.gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/softirq.c')
-rw-r--r-- | kernel/softirq.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/softirq.c b/kernel/softirq.c index d4d918a91881..c10150cb456b 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c @@ -853,7 +853,7 @@ static int __cpuinit cpu_callback(struct notifier_block *nfb, cpumask_any(cpu_online_mask)); case CPU_DEAD: case CPU_DEAD_FROZEN: { - static struct sched_param param = { + static const struct sched_param param = { .sched_priority = MAX_RT_PRIO-1 }; |