summaryrefslogtreecommitdiff
path: root/kernel/sched
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2024-09-10 02:42:47 +0300
committerTejun Heo <tj@kernel.org>2024-09-10 02:42:47 +0300
commit1389f49098981a525ca9fb752b86a4ae874125a8 (patch)
treebc3808a31cf235c07e5649b8c72a2ae5937e9fdc /kernel/sched
parent18f856991d0596aa125cf63893ca08d7c74b85a2 (diff)
downloadlinux-1389f49098981a525ca9fb752b86a4ae874125a8.tar.xz
sched_ext: Reorder args for consume_local/remote_task()
Reorder args for consistency in the order of: current_rq, p, src_[rq|dsq], dst_[rq|dsq]. No functional changes intended. Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'kernel/sched')
-rw-r--r--kernel/sched/ext.c14
1 files changed, 7 insertions, 7 deletions
diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
index 2f93dcb9adf4..bf2b9d2007cf 100644
--- a/kernel/sched/ext.c
+++ b/kernel/sched/ext.c
@@ -2208,8 +2208,8 @@ static void move_task_to_local_dsq(struct task_struct *p, u64 enq_flags,
#endif /* CONFIG_SMP */
-static void consume_local_task(struct rq *rq, struct scx_dispatch_q *dsq,
- struct task_struct *p)
+static void consume_local_task(struct task_struct *p,
+ struct scx_dispatch_q *dsq, struct rq *rq)
{
lockdep_assert_held(&dsq->lock); /* released on return */
@@ -2318,8 +2318,8 @@ static bool unlink_dsq_and_lock_src_rq(struct task_struct *p,
!WARN_ON_ONCE(src_rq != task_rq(p));
}
-static bool consume_remote_task(struct rq *this_rq, struct scx_dispatch_q *dsq,
- struct task_struct *p, struct rq *src_rq)
+static bool consume_remote_task(struct rq *this_rq, struct task_struct *p,
+ struct scx_dispatch_q *dsq, struct rq *src_rq)
{
raw_spin_rq_unlock(this_rq);
@@ -2334,7 +2334,7 @@ static bool consume_remote_task(struct rq *this_rq, struct scx_dispatch_q *dsq,
}
#else /* CONFIG_SMP */
static inline bool task_can_run_on_remote_rq(struct task_struct *p, struct rq *rq, bool trigger_error) { return false; }
-static inline bool consume_remote_task(struct rq *rq, struct scx_dispatch_q *dsq, struct task_struct *p, struct rq *task_rq) { return false; }
+static inline bool consume_remote_task(struct rq *this_rq, struct task_struct *p, struct scx_dispatch_q *dsq, struct rq *task_rq) { return false; }
#endif /* CONFIG_SMP */
static bool consume_dispatch_q(struct rq *rq, struct scx_dispatch_q *dsq)
@@ -2355,12 +2355,12 @@ retry:
struct rq *task_rq = task_rq(p);
if (rq == task_rq) {
- consume_local_task(rq, dsq, p);
+ consume_local_task(p, dsq, rq);
return true;
}
if (task_can_run_on_remote_rq(p, rq, false)) {
- if (likely(consume_remote_task(rq, dsq, p, task_rq)))
+ if (likely(consume_remote_task(rq, p, dsq, task_rq)))
return true;
goto retry;
}