diff options
| author | Gregory CLEMENT <gregory.clement@bootlin.com> | 2019-09-18 13:03:44 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2019-09-18 13:12:24 +0300 |
| commit | 0dce49efc70536a8c3b4bb5354a71b727ba31b80 (patch) | |
| tree | 5ad1e15f8f6188b90de37bb6f0ab025ad07b106b /kernel/delayacct.c | |
| parent | a0a4bf57a977ed37bcbdfc8027a44485fe086a3d (diff) | |
| download | linux-0dce49efc70536a8c3b4bb5354a71b727ba31b80.tar.xz | |
ASoC: atmel_ssc_dai: Remove wrong spinlock usage
A potential bug was reported in the email "[BUG] atmel_ssc_dai: a
possible sleep-in-atomic bug in atmel_ssc_shutdown"[1]
Indeed in the function atmel_ssc_shutdown() free_irq() was called in a
critical section protected by spinlock.
However this spinlock is only used in atmel_ssc_shutdown() and
atmel_ssc_startup() functions. After further analysis, it occurred that
the call to these function are already protected by mutex used on the
calling functions.
Then we can remove the spinlock which will fix this bug as a side
effect. Thanks to this patch the following message disappears:
"BUG: sleeping function called from invalid context at
kernel/locking/mutex.c:909"
[1]: https://www.spinics.net/lists/alsa-devel/msg71286.html
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Link: https://lore.kernel.org/r/20190918100344.23629-1-gregory.clement@bootlin.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'kernel/delayacct.c')
0 files changed, 0 insertions, 0 deletions