summaryrefslogtreecommitdiff
path: root/kernel/audit_watch.c
diff options
context:
space:
mode:
authorEric Dumazet <edumazet@google.com>2021-09-14 08:18:51 +0300
committerDavid S. Miller <davem@davemloft.net>2021-09-14 16:24:31 +0300
commitd198b27762644c71362e43a7533f89c92b115bcf (patch)
tree7650f671289f847a7a157ce5c4d346bcf20d7cfd /kernel/audit_watch.c
parent4f884f3962767877d7aabbc1ec124d2c307a4257 (diff)
downloadlinux-d198b27762644c71362e43a7533f89c92b115bcf.tar.xz
Revert "Revert "ipv4: fix memory leaks in ip_cmsg_send() callers""
This reverts commit d7807a9adf4856171f8441f13078c33941df48ab. As mentioned in https://lkml.org/lkml/2021/9/13/1819 5 years old commit 919483096bfe ("ipv4: fix memory leaks in ip_cmsg_send() callers") was a correct fix. ip_cmsg_send() can loop over multiple cmsghdr() If IP_RETOPTS has been successful, but following cmsghdr generates an error, we do not free ipc.ok If IP_RETOPTS is not successful, we have freed the allocated temporary space, not the one currently in ipc.opt. Sure, code could be refactored, but let's not bring back old bugs. Fixes: d7807a9adf48 ("Revert "ipv4: fix memory leaks in ip_cmsg_send() callers"") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Yajun Deng <yajun.deng@linux.dev> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'kernel/audit_watch.c')
0 files changed, 0 insertions, 0 deletions