summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorSahitya Tummala <stummala@codeaurora.org>2017-07-11 01:49:57 +0300
committerLinus Torvalds <torvalds@linux-foundation.org>2017-07-11 02:32:33 +0300
commit2c80cd57c74339889a8752b20862a16c28929c3a (patch)
tree91fe60fcb168a485c9616b2adb36a11eb719f5fa /include
parent32e4e6d5cbb0c0e427391635991fe65e17797af8 (diff)
downloadlinux-2c80cd57c74339889a8752b20862a16c28929c3a.tar.xz
mm/list_lru.c: fix list_lru_count_node() to be race free
list_lru_count_node() iterates over all memcgs to get the total number of entries on the node but it can race with memcg_drain_all_list_lrus(), which migrates the entries from a dead cgroup to another. This can return incorrect number of entries from list_lru_count_node(). Fix this by keeping track of entries per node and simply return it in list_lru_count_node(). Link: http://lkml.kernel.org/r/1498707555-30525-1-git-send-email-stummala@codeaurora.org Signed-off-by: Sahitya Tummala <stummala@codeaurora.org> Acked-by: Vladimir Davydov <vdavydov.dev@gmail.com> Cc: Jan Kara <jack@suse.cz> Cc: Alexander Polakov <apolyakov@beget.ru> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include')
-rw-r--r--include/linux/list_lru.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/include/linux/list_lru.h b/include/linux/list_lru.h
index cb0ba9f2a9a2..fa7fd03cb5f9 100644
--- a/include/linux/list_lru.h
+++ b/include/linux/list_lru.h
@@ -44,6 +44,7 @@ struct list_lru_node {
/* for cgroup aware lrus points to per cgroup lists, otherwise NULL */
struct list_lru_memcg *memcg_lrus;
#endif
+ long nr_items;
} ____cacheline_aligned_in_smp;
struct list_lru {