diff options
| author | Harshad Shirwadkar <harshadshirwadkar@gmail.com> | 2020-11-06 06:58:57 +0300 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2020-11-07 07:01:03 +0300 |
| commit | c460e5edc85a063ec9cb60addff93d00ed378701 (patch) | |
| tree | a779fd93ebec507ce8c177c781ce2c7cde1716e2 /include | |
| parent | 37e0a30e94f1aa25f16b403dfabb64e0b806de0b (diff) | |
| download | linux-c460e5edc85a063ec9cb60addff93d00ed378701.tar.xz | |
jbd2: don't use state lock during commit path
Variables journal->j_fc_off, journal->j_fc_wbuf are accessed during
commit path. Since today we allow only one process to perform a fast
commit, there is no need take state lock before accessing these
variables. This patch removes these locks and adds comments to
describe this.
Suggested-by: Jan Kara <jack@suse.cz>
Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Link: https://lore.kernel.org/r/20201106035911.1942128-9-harshadshirwadkar@gmail.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/jbd2.h | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h index b2caf7bbd8e5..5f0ef6380b0c 100644 --- a/include/linux/jbd2.h +++ b/include/linux/jbd2.h @@ -945,8 +945,9 @@ struct journal_s /** * @j_fc_off: * - * Number of fast commit blocks currently allocated. - * [j_state_lock]. + * Number of fast commit blocks currently allocated. Accessed only + * during fast commit. Currently only process can do fast commit, so + * this field is not protected by any lock. */ unsigned long j_fc_off; @@ -1109,8 +1110,9 @@ struct journal_s struct buffer_head **j_wbuf; /** - * @j_fc_wbuf: Array of fast commit bhs for - * jbd2_journal_commit_transaction. + * @j_fc_wbuf: Array of fast commit bhs for fast commit. Accessed only + * during a fast commit. Currently only process can do fast commit, so + * this field is not protected by any lock. */ struct buffer_head **j_fc_wbuf; |