diff options
| author | Varun Prakash <varun@chelsio.com> | 2022-01-22 19:57:44 +0300 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2022-02-23 16:43:11 +0300 |
| commit | c2700d2886a87f83f31e0a301de1d2350b52c79b (patch) | |
| tree | dbcfa128fca5672102867f2ea87cd56134164865 /include | |
| parent | 602e57c9799c19f27e440639deed3ec45cfe1651 (diff) | |
| download | linux-c2700d2886a87f83f31e0a301de1d2350b52c79b.tar.xz | |
nvme-tcp: send H2CData PDUs based on MAXH2CDATA
As per NVMe/TCP specification (revision 1.0a, section 3.6.2.3)
Maximum Host to Controller Data length (MAXH2CDATA): Specifies the
maximum number of PDU-Data bytes per H2CData PDU in bytes. This value
is a multiple of dwords and should be no less than 4,096.
Current code sets H2CData PDU data_length to r2t_length,
it does not check MAXH2CDATA value. Fix this by setting H2CData PDU
data_length to min(req->h2cdata_left, queue->maxh2cdata).
Also validate MAXH2CDATA value returned by target in ICResp PDU,
if it is not a multiple of dword or if it is less than 4096 return
-EINVAL from nvme_tcp_init_connection().
Signed-off-by: Varun Prakash <varun@chelsio.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/nvme-tcp.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/linux/nvme-tcp.h b/include/linux/nvme-tcp.h index 959e0bd9a913..75470159a194 100644 --- a/include/linux/nvme-tcp.h +++ b/include/linux/nvme-tcp.h @@ -12,6 +12,7 @@ #define NVME_TCP_DISC_PORT 8009 #define NVME_TCP_ADMIN_CCSZ SZ_8K #define NVME_TCP_DIGEST_LENGTH 4 +#define NVME_TCP_MIN_MAXH2CDATA 4096 enum nvme_tcp_pfv { NVME_TCP_PFV_1_0 = 0x0, |