diff options
| author | Oliver Hartkopp <socketcan@hartkopp.net> | 2020-10-12 10:43:53 +0300 |
|---|---|---|
| committer | Marc Kleine-Budde <mkl@pengutronix.de> | 2020-10-12 11:06:08 +0300 |
| commit | ac911bfeb34b5d79fb4e23a08b8db0b89c529b53 (patch) | |
| tree | 7ebea0b9527d9446234a3c831fc69d91aed87246 /include/uapi | |
| parent | bc081a693a56061f68f736c5d596134ee3c87689 (diff) | |
| download | linux-ac911bfeb34b5d79fb4e23a08b8db0b89c529b53.tar.xz | |
can: isotp: implement cleanups / improvements from review
As pointed out by Jakub Kicinski here:
http://lore.kernel.org/r/20201009175751.5c54097f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com
this patch addresses the remarked issues:
- remove empty line in comment
- remove default=y for CAN_ISOTP in Kconfig
- make use of pr_notice_once()
- use GFP_ATOMIC instead of gfp_any() in soft hrtimer context
The version strings in the CAN subsystem are removed by a separate patch.
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Link: https://lore.kernel.org/r/20201012074354.25839-1-socketcan@hartkopp.net
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'include/uapi')
| -rw-r--r-- | include/uapi/linux/can/isotp.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/uapi/linux/can/isotp.h b/include/uapi/linux/can/isotp.h index 553006509f4e..7793b26aa154 100644 --- a/include/uapi/linux/can/isotp.h +++ b/include/uapi/linux/can/isotp.h @@ -160,7 +160,6 @@ struct can_isotp_ll_options { * these default settings can be changed via sockopts. * For that reason the STmin value is intentionally _not_ checked for * consistency and copied directly into the flow control (FC) frame. - * */ #endif /* !_UAPI_CAN_ISOTP_H */ |