diff options
| author | Camelia Groza <camelia.groza@nxp.com> | 2019-01-17 15:22:36 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-01-19 21:03:08 +0300 |
| commit | 3e64cf7a435ed0500e3adaa8aada2272d3ae8abc (patch) | |
| tree | e7999c0a0af25273008032ee1b13d1ad64f20aee /include/linux | |
| parent | 7afa81c55fca0cad589722cb4bce698b4803b0e1 (diff) | |
| download | linux-3e64cf7a435ed0500e3adaa8aada2272d3ae8abc.tar.xz | |
net: phy: phy driver features are mandatory
Since phy driver features became a link_mode bitmap, phy drivers that
don't have a list of features configured will cause the kernel to crash
when probed.
Prevent the phy driver from registering if the features field is missing.
Fixes: 719655a14971 ("net: phy: Replace phy driver features u32 with link_mode bitmap")
Reported-by: Scott Wood <oss@buserror.net>
Signed-off-by: Camelia Groza <camelia.groza@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux')
| -rw-r--r-- | include/linux/phy.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/phy.h b/include/linux/phy.h index 55114657a577..ef20aeea10cc 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -469,8 +469,8 @@ struct phy_device { * only works for PHYs with IDs which match this field * name: The friendly name of this PHY type * phy_id_mask: Defines the important bits of the phy_id - * features: A list of features (speed, duplex, etc) supported - * by this PHY + * features: A mandatory list of features (speed, duplex, etc) + * supported by this PHY * flags: A bitfield defining certain other features this PHY * supports (like interrupts) * |