diff options
| author | Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> | 2019-08-06 03:55:06 +0300 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2019-08-21 12:06:01 +0300 |
| commit | 05c8afe42559c98f89022431e457bfbdaf01c806 (patch) | |
| tree | ba6c5482009bbb8af24fa372f6dd91cd0ab2baa6 /include/linux/soundwire | |
| parent | 15ed3ea2280e3afaea82afa664a6d1adc65b0009 (diff) | |
| download | linux-05c8afe42559c98f89022431e457bfbdaf01c806.tar.xz | |
soundwire: intel: prevent possible dereference in hw_params
This should not happen in production systems but we should test for
all callback arguments before invoking the config_stream callback.
Update the prototype to clarify that the first argument is mandatory.
Also use local variable instead of multiple dereferences to improve
readability.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20190806005522.22642-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'include/linux/soundwire')
| -rw-r--r-- | include/linux/soundwire/sdw_intel.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/linux/soundwire/sdw_intel.h b/include/linux/soundwire/sdw_intel.h index 4d70da45363d..c9427cb6020b 100644 --- a/include/linux/soundwire/sdw_intel.h +++ b/include/linux/soundwire/sdw_intel.h @@ -8,6 +8,7 @@ * struct sdw_intel_ops: Intel audio driver callback ops * * @config_stream: configure the stream with the hw_params + * the first argument containing the context is mandatory */ struct sdw_intel_ops { int (*config_stream)(void *arg, void *substream, |