diff options
author | Johannes Weiner <hannes@cmpxchg.org> | 2020-03-16 22:13:32 +0300 |
---|---|---|
committer | Peter Zijlstra <peterz@infradead.org> | 2020-03-20 15:06:19 +0300 |
commit | 36b238d5717279163859fb6ba0f4360abcafab83 (patch) | |
tree | 1b3282b27b593262f09686f704b1e00767ff76f6 /include/linux/psi.h | |
parent | b05e75d611380881e73edc58a20fd8c6bb71720b (diff) | |
download | linux-36b238d5717279163859fb6ba0f4360abcafab83.tar.xz |
psi: Optimize switching tasks inside shared cgroups
When switching tasks running on a CPU, the psi state of a cgroup
containing both of these tasks does not change. Right now, we don't
exploit that, and can perform many unnecessary state changes in nested
hierarchies, especially when most activity comes from one leaf cgroup.
This patch implements an optimization where we only update cgroups
whose state actually changes during a task switch. These are all
cgroups that contain one task but not the other, up to the first
shared ancestor. When both tasks are in the same group, we don't need
to update anything at all.
We can identify the first shared ancestor by walking the groups of the
incoming task until we see TSK_ONCPU set on the local CPU; that's the
first group that also contains the outgoing task.
The new psi_task_switch() is similar to psi_task_change(). To allow
code reuse, move the task flag maintenance code into a new function
and the poll/avg worker wakeups into the shared psi_group_change().
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20200316191333.115523-3-hannes@cmpxchg.org
Diffstat (limited to 'include/linux/psi.h')
-rw-r--r-- | include/linux/psi.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/include/linux/psi.h b/include/linux/psi.h index 7b3de7321219..7361023f3fdd 100644 --- a/include/linux/psi.h +++ b/include/linux/psi.h @@ -17,6 +17,8 @@ extern struct psi_group psi_system; void psi_init(void); void psi_task_change(struct task_struct *task, int clear, int set); +void psi_task_switch(struct task_struct *prev, struct task_struct *next, + bool sleep); void psi_memstall_tick(struct task_struct *task, int cpu); void psi_memstall_enter(unsigned long *flags); |