diff options
| author | Huacai Chen <chenhc@lemote.com> | 2017-11-21 16:23:39 +0300 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2017-11-22 07:06:32 +0300 |
| commit | c2e8fbf908afd81ad502b567a6639598f92c9b9d (patch) | |
| tree | da52dc8f0f0298711ddb13259e95e88668bf8a1d /include/linux/pm_qos.h | |
| parent | 90addc6b3c9cda0146fbd62a08e234c2b224a80c (diff) | |
| download | linux-c2e8fbf908afd81ad502b567a6639598f92c9b9d.tar.xz | |
scsi: libsas: align sata_device's rps_resp on a cacheline
The rps_resp buffer in ata_device is a DMA target, but it isn't
explicitly cacheline aligned. Due to this, adjacent fields can be
overwritten with stale data from memory on non-coherent architectures.
As a result, the kernel is sometimes unable to communicate with an SATA
device behind a SAS expander.
Fix this by ensuring that the rps_resp buffer is cacheline aligned.
This issue is similar to that fixed by Commit 84bda12af31f93 ("libata:
align ap->sector_buf") and Commit 4ee34ea3a12396f35b26 ("libata: Align
ata_device's id on a cacheline").
Cc: stable@vger.kernel.org
Signed-off-by: Huacai Chen <chenhc@lemote.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'include/linux/pm_qos.h')
0 files changed, 0 insertions, 0 deletions