diff options
| author | Jason Wang <jasowang@redhat.com> | 2014-03-26 09:03:00 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-03-27 21:13:21 +0400 |
| commit | 681daee2443291419c57cccb0671f5f94a839005 (patch) | |
| tree | e6c47044894798c2b838e535bbca0d412a4ce3c6 /include/linux/percpu_ida.h | |
| parent | de1443916791d75fdd26becb116898277bb0273f (diff) | |
| download | linux-681daee2443291419c57cccb0671f5f94a839005.tar.xz | |
virtio-net: correct error handling of virtqueue_kick()
Current error handling of virtqueue_kick() was wrong in two places:
- The skb were freed immediately when virtqueue_kick() fail during
xmit. This may lead double free since the skb was not detached from
the virtqueue.
- try_fill_recv() returns false when virtqueue_kick() fail. This will
lead unnecessary rescheduling of refill work.
Actually, it's safe to just ignore the kick failure in those two
places. So this patch fixes this by partially revert commit
67975901183799af8e93ec60e322f9e2a1940b9b.
Fixes 67975901183799af8e93ec60e322f9e2a1940b9b
(virtio_net: verify if virtqueue_kick() succeeded).
Cc: Heinz Graalfs <graalfs@linux.vnet.ibm.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/percpu_ida.h')
0 files changed, 0 insertions, 0 deletions