diff options
| author | James Smart <jsmart2021@gmail.com> | 2017-03-24 06:41:27 +0300 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2017-04-04 18:48:23 +0300 |
| commit | 62eeacb0e04f2aff7099a7765f386bb7ba53d5e2 (patch) | |
| tree | 0ada4a3ef80d8a0a17bb65c9c6be0a6604269329 /include/linux/nvme-fc-driver.h | |
| parent | c820ad4cdacbb272ec993738d1c7eb96f09ddcd5 (diff) | |
| download | linux-62eeacb0e04f2aff7099a7765f386bb7ba53d5e2.tar.xz | |
nvme_fc: Clean up host fcpio done status handling
As Dan Carpenter pointed out: mixing 16-bit nvme status with 32-bit
error status from driver. Corrected comment on fcp request struct
status field, and converted done routine to explicitly set nvme status
codes for nvme status.
Signed-off-by: James Smart <james.smart@broadcom.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'include/linux/nvme-fc-driver.h')
| -rw-r--r-- | include/linux/nvme-fc-driver.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/include/linux/nvme-fc-driver.h b/include/linux/nvme-fc-driver.h index f21471f7ee40..16eb264980c2 100644 --- a/include/linux/nvme-fc-driver.h +++ b/include/linux/nvme-fc-driver.h @@ -137,9 +137,9 @@ enum nvmefc_fcp_datadir { * transferred. Should equal payload_length on success. * @rcv_rsplen: length, in bytes, of the FCP RSP IU received. * @status: Completion status of the FCP operation. must be 0 upon success, - * NVME_SC_FC_xxx value upon failure. Note: this is NOT a - * reflection of the NVME CQE completion status. Only the status - * of the FCP operation at the NVME-FC level. + * negative errno value upon failure (ex: -EIO). Note: this is + * NOT a reflection of the NVME CQE completion status. Only the + * status of the FCP operation at the NVME-FC level. */ struct nvmefc_fcp_req { void *cmdaddr; |